add interactive method to distributions #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 78.71% 77.45% -1.26%
==========================================
Files 18 18
Lines 2119 2165 +46
==========================================
+ Hits 1668 1677 +9
- Misses 451 488 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #144. This allows setting the parameters of distribution interactively using sliders.
There are still some issues, but I left those for future PRs. For example, the user needs to define starting values, but it could be useful to offer some arbitrary values by default, especially for newbie users and/or not very common distributions. There is also a dirty heuristic to define the min, max, and step values of sliders, which could be better, etc.